DRYD-1242: Fix unnecessary re-authorization. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This fixes a bug (introduced with the Spring Security upgrade/switch to OAuth authorization code grant) where the logged in user is not updated properly in the redux store. This resulted in unnecessary re-authorization when a valid stored token was present.
Why are we doing this? (with JIRA link)
This is part of the Spring Security upgrade: https://collectionspace.atlassian.net/browse/DRYD-1242
How should this be tested? Do these changes have associated tests?
Log in, browse to a record, and reload the browser. Upon reload, re-authorization should not occur (there is no request to the /cspace-services/oauth2/authorize endpoint, and no resulting redirect to the /authorized page in the UI).
Dependencies for merging? Releasing to production?
None.
Has the application documentation been updated for these changes?
n/a
Did someone actually run this code to verify it works?
@ray-lee ran this locally.