fix: bigint coerce crash #3822
Open
fix: bigint coerce crash #3822
+32
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hdsuperman
reviewed
Nov 23, 2024
deno/lib/types.ts
Outdated
| try { | ||
| input.data = BigInt(input.data); | ||
| } catch { | ||
| input.data = undefined; |
There was a problem hiding this comment.
Maybe here should return INVALID instate of undefined
There was a problem hiding this comment.
That works and looks more correct 👍🏻
hdsuperman
reviewed
Nov 23, 2024
src/types.ts
Outdated
| try { | ||
| input.data = BigInt(input.data); | ||
| } catch { | ||
| input.data = undefined; |
There was a problem hiding this comment.
Maybe here should return INVALID instate of undefined
There was a problem hiding this comment.
That works and looks more correct 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when parse is executed through
isOptionalcheck onZodBigIntwhich adds aundefinedsafeParse execution to look for errors, it crashes when attempting to addundefinedto BigInt as its an invalid value.One fix here is to just try catch the instantiation and cast the coerced value to
undefinedif it throws and error. This way all parser checks will fail on invalid values but not crash on internal checks which provides undefined as the input value.Perhaps another approach could be to just catch and ignore the error and let the input data checks to subsequently verify that the input value is valid. 🤔
closes #3821