Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/QueryString and Feature/Security #12

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

RichardTMiles
Copy link

This pull request fixes the issue of nested objects in a JSON payload sent through a POST request.

nodejs/node-v0.x-archive#1665

The library "querystring" is replaced with "qs". This packed was already installed via dependancy.

The "qs" package has an export "stringify" so no additional coding was required.
( I got pretty lucky )

I have also added the following to the package.json
"prepare": "npm run build"

I could not get npm to download the forked repository with src files. It expects the download to already be compiled unless the above snippet is attached. GitHub doesn't build the project like npm, so the only other trivial ways to achieve collaborating was to add my fork to npm or remove lib from the .gitignore and commit the folder to github. These two options seemed excessive when compared with the above, so I suggest leaving it in the package. I am not a node expert, so if this is a breaking change then we should possibly just add the process to the documentation.

____________ 2/6/2020

Added security option to disable ssl validation on a per mapping level

Best,
Richard Miles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant