Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

一些图片的label错误 #19

Closed
colinaaa opened this issue Dec 1, 2020 · 0 comments · Fixed by #22
Closed

一些图片的label错误 #19

colinaaa opened this issue Dec 1, 2020 · 0 comments · Fixed by #22
Assignees
@colinaaa
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@colinaaa
Copy link
Owner

colinaaa commented Dec 1, 2020

algorithm-course-notes/src/Network-flows.tex

Line 35 in 99741ef

\caption{极大匹配举例}\label{fig1}

与

algorithm-course-notes/src/Image-segmentation.tex

Line 37 in 99741ef

\caption{图片前景背景识别}\label{fig2}

中均使用fig1, fig2 这样的label来标识图片，导致了build的过程中引用混乱。

计划：

  • 修复问题，增加图片label的作用域（如：\label{fig:network-flow1}）
  • 增加文档，规范化label名称（最好不使用1，2，3，而是使用有意义的名称）
  • code review时注意类似问题⚠️
@colinaaa colinaaa added bug Something isn't working good first issue Good for newcomers labels Dec 1, 2020
@colinaaa colinaaa self-assigned this Dec 1, 2020
colinaaa added a commit that referenced this issue Dec 2, 2020
@colinaaa
feat(label): change most of ambiguous labels to meaningful labels
e6892a2 
also adjust some environments

re #19
colinaaa added a commit that referenced this issue Dec 2, 2020
@colinaaa
feat(label): modify label in Ln9 nearest points
743d7c6 
use figure file name as label name

re #19
colinaaa added a commit that referenced this issue Dec 2, 2020
@colinaaa
feat(label): change label in chapter image segmentation
3888638 
also reformat with latexindent

fix #19
@colinaaa colinaaa mentioned this issue Dec 2, 2020
Merged
colinaaa added a commit that referenced this issue Dec 2, 2020
@colinaaa
docs(label): update readme
9b5bdf2 
add label content suggestions

re #19
colinaaa added a commit that referenced this issue Dec 3, 2020
@colinaaa
feat(label): resolve label conflicts (#22)
a3d6bb5 
* feat(label): change most of ambiguous labels to meaningful labels

also adjust some environments

re #19

* feat(label): modify label in Ln9 nearest points

use figure file name as label name

re #19

* feat(label): change label in chapter image segmentation

also reformat with latexindent

fix #19

docs(label): update readme
add label content suggestions

re #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinaaa colinaaa

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix figure and others' label conflict colinaaa/algorithm-course-notes
1 participant
@colinaaa