Allow title display of static contact element to be invisible or none #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This twig template change enables the expected behaviour of setting the element Title Display to 'invisible' or 'none'.
Before
If you create a webform with a CiviCRM Contact element, set the Form Widget to Static, and set the Title Display for that element to 'invisible' or 'none', the Title is still displayed.
After
Setting the Title Display to
'invisible'
will result in the label gaining thehidden
attribute. Setting the Title Display to'none'
will omit the label from the output.Technical Details
This changes two lines of the Twig template, adding to one existing conditional so the label will be omitted if the
#title_display
is'none'
, and then adding a new conditional to decide whether the label should get thehidden
attribute.