Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backboned project #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

backboned project #2

wants to merge 1 commit into from

Conversation

RianaFerreira
Copy link

Applied the backbone framework for JS files.

@coldhead
Copy link
Owner

coldhead commented Jan 4, 2014

Riana!

Happy New Year!

I just went to merge your pull request and found that your version gives me an error in AppRouter.js when I try to load the default route:

Uncaught ReferenceError: PhraseBook is not defined

Would you like to fix that and submit again? No hurry :)

@RianaFerreira
Copy link
Author

Hi Joel :)

Sorry about that! This is terribly embarrassing, I will do my best to get
it sorted as soon as possible.

Happy New Year to you too, may it be filled with bountiful beautiful
butterflies!

Cheerio,
Ri

On 4 January 2014 21:04, coldhead [email protected] wrote:

Riana!

Happy New Year!

I just went to merge your pull request and found that your version gives
me an error in AppRouter.js when I try to load the default route:

Uncaught ReferenceError: PhraseBook is not defined

Would you like to fix that and submit again? No hurry :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-31575259
.

@chee
Copy link
Collaborator

chee commented Jan 8, 2014

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants