-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(QueryBuilder): Upgrade cbpaginator to fix maxrows discrepency
cbpaginator would clamp the `maxrows` between 0 and a configured maximum. qb, however, would execute the query before this clamping. This means that the length of the results was different than the reported `maxrows`. The new version of `cbpaginator` does not do any clamping. Please handle that in your application. This change is NOT breaking because qb never used the clamped value. This fix is just fixing the discrepency between the results length and the reported maxrows value in the returned pagination struct.
- Loading branch information
Showing
1 changed file
with
35 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,56 @@ | ||
{ | ||
"name":"qb", | ||
"version":"7.5.1", | ||
"author":"Eric Peterson", | ||
"homepage":"https://github.com/coldbox-modules/qb", | ||
"documentation":"https://github.com/coldbox-modules/qb", | ||
"location":"forgeboxStorage", | ||
"scripts":{ | ||
"generateAPIDocs":"rm .tmp --recurse --force && docbox generate mapping=qb excludes=test|ModuleConfig strategy-outputDir=.tmp/apidocs strategy-projectTitle=qb", | ||
"commitAPIDocs":"run-script generateAPIDocs && !git add docs/apidocs/* && !git commit -m 'Updated API Docs'", | ||
"format":"cfformat run models/**/*.cfc,tests/resources/**/*.cfc,tests/specs/**/*.cfc --overwrite", | ||
"format:check":"cfformat check models/**/*.cfc,tests/resources/**/*.cfc,tests/specs/**/*.cfc" | ||
"name": "qb", | ||
"version": "7.5.1", | ||
"author": "Eric Peterson", | ||
"homepage": "https://github.com/coldbox-modules/qb", | ||
"documentation": "https://github.com/coldbox-modules/qb", | ||
"location": "forgeboxStorage", | ||
"scripts": { | ||
"generateAPIDocs": "rm .tmp --recurse --force && docbox generate mapping=qb excludes=test|ModuleConfig strategy-outputDir=.tmp/apidocs strategy-projectTitle=qb", | ||
"commitAPIDocs": "run-script generateAPIDocs && !git add docs/apidocs/* && !git commit -m 'Updated API Docs'", | ||
"format": "cfformat run models/**/*.cfc,tests/resources/**/*.cfc,tests/specs/**/*.cfc --overwrite", | ||
"format:check": "cfformat check models/**/*.cfc,tests/resources/**/*.cfc,tests/specs/**/*.cfc" | ||
}, | ||
"repository":{ | ||
"type":"git", | ||
"URL":"https://github.com/coldbox-modules/qb" | ||
"repository": { | ||
"type": "git", | ||
"URL": "https://github.com/coldbox-modules/qb" | ||
}, | ||
"bugs":"https://github.com/coldbox-modules/qb/issues", | ||
"slug":"qb", | ||
"shortDescription":"A query builder for the rest of us", | ||
"type":"modules", | ||
"keywords":[ | ||
"bugs": "https://github.com/coldbox-modules/qb/issues", | ||
"slug": "qb", | ||
"shortDescription": "A query builder for the rest of us", | ||
"type": "modules", | ||
"keywords": [ | ||
"ORM", | ||
"query", | ||
"SQL" | ||
], | ||
"private":false, | ||
"projectURL":"https://github.com/coldbox-modules/qb", | ||
"license":[ | ||
"private": false, | ||
"projectURL": "https://github.com/coldbox-modules/qb", | ||
"license": [ | ||
{ | ||
"type":"MIT", | ||
"URL":"https://github.com/coldbox-modules/qb/LICENSE" | ||
"type": "MIT", | ||
"URL": "https://github.com/coldbox-modules/qb/LICENSE" | ||
} | ||
], | ||
"dependencies":{ | ||
"cbpaginator":"^1.3.0", | ||
"coldbox":"stable" | ||
"dependencies": { | ||
"cbpaginator": "^2.0.0" | ||
}, | ||
"devDependencies":{ | ||
"testbox":"^3.0.0" | ||
"devDependencies": { | ||
"testbox": "^3.0.0" | ||
}, | ||
"installPaths":{ | ||
"testbox":"testbox/", | ||
"cbpaginator":"modules/cbpaginator/", | ||
"coldbox":"coldbox/" | ||
"installPaths": { | ||
"testbox": "testbox/", | ||
"cbpaginator": "modules/cbpaginator/" | ||
}, | ||
"ignore":[ | ||
"ignore": [ | ||
"**/.*", | ||
"test", | ||
"tests", | ||
"docs/**/*.*", | ||
"server.json" | ||
], | ||
"testbox":{ | ||
"runner":"http://localhost:7777/tests/runner.cfm", | ||
"verbose":false | ||
"testbox": { | ||
"runner": "http://localhost:7777/tests/runner.cfm", | ||
"verbose": false | ||
} | ||
} |