Add AMENT_PREFIX_PATH environment hook #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <[email protected]>
esteve
reviewed
Aug 11, 2020
|
@jacobperron thanks! Sorry I forgot about this one. I only have one question, but overall it looks good. |
Signed-off-by: Jacob Perron <[email protected]>
|
I think this PR is ready. @esteve @ivanpauno, if either of you give me an approval I'll merge it. |
|
Hi, |
ivanpauno
approved these changes
Jan 6, 2022
| @@ -23,6 +25,21 @@ def add_arguments(self, *, parser): # noqa: D102 | |||
| '--ament-gradle-task', | |||
| help='Run a specific task instead of the default task') | |||
|
|
|||
| async def build( | |||
| self, *, additional_hooks=[], skip_hook_creation=False | |||
| ): # noqa: D102 | |||
There was a problem hiding this comment.
question: what is this noqa for?
There was a problem hiding this comment.
"Missing docstring in public method"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to a problem described in ros2-java/ament_java#9
TL;DR
Gradle projects are not being added to the AMENT_PREFIX_PATH; this PR let's colcon handle it.