Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoke pytest directly instead of through the setup.py file #296

Merged
merged 1 commit into from
Jan 30, 2020
Merged

invoke pytest directly instead of through the setup.py file #296

merged 1 commit into from
Jan 30, 2020

Conversation

dirk-thomas
Copy link
Member

As of setuptools 41.5.0 invoking tests through the setup.py file is deprecated (see pypa/setuptools#1878):

WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.

This PR only changes the pytest based testing extension.

@dirk-thomas dirk-thomas self-assigned this Jan 29, 2020
@dirk-thomas dirk-thomas mentioned this pull request Jan 29, 2020
Closed
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/remove-pytest-runner branch 2 times, most recently from e8a1100 to 3f58730 Compare January 29, 2020 23:49
jacobperron
jacobperron approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@dirk-thomas dirk-thomas mentioned this pull request Jan 29, 2020
Merged
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/remove-pytest-runner branch from e848304 to 7a4e8db Compare January 30, 2020 00:05
@dirk-thomas
Copy link
Member Author

Rebases after merging #297 and #298.

@dirk-thomas dirk-thomas merged commit 01d3eb0 into master Jan 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/remove-pytest-runner branch January 30, 2020 00:08
@dirk-thomas dirk-thomas added this to the 0.5.3 milestone Jan 30, 2020
@dirk-thomas dirk-thomas mentioned this pull request Jan 30, 2020
Merged
@dirk-thomas dirk-thomas mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @jacobperron