Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple workaround to avoid crash on workspace #25

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

cdussieux
Copy link
Contributor

No description provided.

Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on whether the fix is the correct one or not but we are encountering the same issue in rmf_site and this fixes it.

To reproduce, I cloned rmf_site in the workspace and tried a colcon build.

Without this PR the following error is returned:

--- stderr: rmf_site                                                                                                                                                                                         
error: found a virtual manifest at `/usr/local/google/home/lucadv/rmf_ws/src/rmf_site/Cargo.toml` instead of a package manifest
---
Failed   <<< rmf_site [1.22s, exited with code 101]

However after forcing a reinstall and using the PR's colcon-cargo:

pip3 install --user --force-reinstall git+https://github.com/pollen-robotics/colcon-cargo.git

The package builds and runs correctly.
For this reason I'm tentatively approving this to at least unblock the workspace workflows.

@mxgrey mxgrey merged commit 2f1dc54 into colcon:main Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants