Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Component Page #59

Merged
merged 16 commits into from
Jan 9, 2024
Merged

refactor: Component Page #59

merged 16 commits into from
Jan 9, 2024

Conversation

salvatorecriscioneweb
Copy link
Contributor

@salvatorecriscioneweb salvatorecriscioneweb commented Jan 2, 2024 •
edited
Loading

Note:

  • Optimized useGetExamples ( using correct use word in the begin ), together with React.cache ( Experimental )
  • Removed page.tsx totally
  • Removed props.ts
  • Created props.json
  • Added the support the types generation for JSON file
  • Added the support of the props in the types generation
  • Fixed some minor bugs

@salvatorecriscioneweb salvatorecriscioneweb added the enhancement New feature or request label Jan 3, 2024
@salvatorecriscioneweb salvatorecriscioneweb marked this pull request as ready for review January 3, 2024 15:30
karl-kallavus
karl-kallavus requested changes Jan 8, 2024
View reviewed changes
docs/app/client/[...slug]/page.tsx Outdated Show resolved Hide resolved
docs/app/client/[...slug]/page.tsx Outdated Show resolved Hide resolved
docs/components/ComponentImage.tsx Outdated Show resolved Hide resolved
docs/package.json Outdated Show resolved Hide resolved
docs/app/client/[...slug]/page.tsx Outdated Show resolved Hide resolved
docs/app/client/[...slug]/page.tsx Outdated Show resolved Hide resolved
docs/app/client/[...slug]/page.tsx Outdated Show resolved Hide resolved
docs/app/client/[...slug]/page.tsx Outdated Show resolved Hide resolved
docs/.eslintrc.json Show resolved Hide resolved
docs/app/client/accordion/description.md Show resolved Hide resolved
@salvatorecriscioneweb salvatorecriscioneweb merged commit 9ead53c into main Jan 9, 2024
4 checks passed
@salvatorecriscioneweb salvatorecriscioneweb deleted the salvatorecriscione/minor-refactor-2-jan-page branch January 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-kallavus karl-kallavus karl-kallavus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salvatorecriscioneweb @karl-kallavus