Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open options list on input focus [MDS-1378] #219

Merged
merged 19 commits into from
Dec 11, 2024
Merged

fix: open options list on input focus [MDS-1378] #219

merged 19 commits into from
Dec 11, 2024

Conversation

MarioGranada
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: ed3a916

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@heathmont/moon-core-tw Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@dkireev dkireev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In examples with Combobox.Select when no option is selected navigating with TAB sets the first option from the list. Should open dropdown and then blur out without selecting anything

@MarioGranada MarioGranada requested a review from dkireev December 5, 2024 14:08
@MarioGranada
Copy link
Contributor Author

Agreed. Just made a fix @dkireev , please have a look.

@dkireev dkireev merged commit 5718ac9 into main Dec 11, 2024
5 checks passed
@dkireev dkireev deleted the MDS-1378 branch December 11, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants