feat: Accordion Example MDS-855 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatorecriscioneweb
suggested changes
Dec 13, 2023
| const COMPONENT_NAME = "accordion"; | ||
| const MAX_DIFF_PIXEL_RATIO = 0.01; | ||
|
|
||
| const DEFAULT_TIMEOUT = 1000; // We wait max for 1 second for mounting |
There was a problem hiding this comment.
// TODO
I assume we could store this variable somewhere.
There was a problem hiding this comment.
Yeah my idea is pretty standard, create a consts directory, create the file index.ts to have the import point, then create playwright.ts and put there with a prefix PLAYWRIGHT_, we avoid any conflicts in the future, and it make easy understand what is what
salvatorecriscioneweb
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.