fix: build, eslint MDS-919 (#42)

* fix: build, eslint MDS-919 * Prettified Code!
coingaming · Dec 22, 2023 · 74d5f1a · 74d5f1a
1 parent 23397ae
commit 74d5f1a
Show file tree

Hide file tree

Showing 9 changed files with 66 additions and 38 deletions.
diff --git a/docs/app/client/authcode/examples/ErrorState.tsx b/docs/app/client/authcode/examples/ErrorState.tsx
@@ -30,7 +30,7 @@ export const ErrorState = () => {
   // Trigger validation for this example
   useEffect(() => {
     trigger("authCode");
-  }, []);
+  }, [trigger]);
   return (
     <Form
       onSubmit={handleSubmit(onSubmit)}

diff --git a/docs/app/client/breadcrumb/examples/Collapsed.tsx b/docs/app/client/breadcrumb/examples/Collapsed.tsx
@@ -4,12 +4,22 @@ import React from "react";
 import { Breadcrumb } from "@heathmont/moon-core-tw";
 
 const breadcrumbs = [
-  <a href="#">Home</a>,
-  <a href="#">Page 1</a>,
-  <a href="#">Page 2</a>,
-  <a href="#">Page 3</a>,
-  <a href="#">Page 4</a>,
-  <span>Current page</span>,
+  <a href="#" key="Home">
+    Home
+  </a>,
+  <a href="#" key="Page 1">
+    Page 1
+  </a>,
+  <a href="#" key="Page 2">
+    Page 2
+  </a>,
+  <a href="#" key="Page 3">
+    Page 3
+  </a>,
+  <a href="#" key="Page 4">
+    Page 4
+  </a>,
+  <span key="Current">Current page</span>,
 ];
 
 export const Collapsed = () => {

diff --git a/docs/app/client/breadcrumb/examples/CustomDivider.tsx b/docs/app/client/breadcrumb/examples/CustomDivider.tsx
@@ -5,14 +5,22 @@ import { Breadcrumb } from "@heathmont/moon-core-tw";
 import { GenericHome, ControlsChevronRight } from "@heathmont/moon-icons-tw";
 
 const breadcrumbs = [
-  <a href="#" aria-label="Home">
+  <a href="#" aria-label="Home" key="Home">
     <GenericHome className="text-moon-24" />
   </a>,
-  <a href="#">Page 1</a>,
-  <a href="#">Page 2</a>,
-  <a href="#">Page 3</a>,
-  <a href="#">Page 4</a>,
-  <span>Current page</span>,
+  <a href="#" key="Page 1">
+    Page 1
+  </a>,
+  <a href="#" key="Page 2">
+    Page 2
+  </a>,
+  <a href="#" key="Page 3">
+    Page 3
+  </a>,
+  <a href="#" key="Page 5">
+    Page 4
+  </a>,
+  <span key="Current">Current page</span>,
 ];
 
 export const CustomDivider = () => {

diff --git a/docs/app/client/breadcrumb/examples/FourItems.tsx b/docs/app/client/breadcrumb/examples/FourItems.tsx
@@ -4,10 +4,16 @@ import React from "react";
 import { Breadcrumb } from "@heathmont/moon-core-tw";
 
 const breadcrumbs = [
-  <a href="#">Home</a>,
-  <a href="#">Page 1</a>,
-  <a href="#">Page 2</a>,
-  <span>Current page</span>,
+  <a href="#" key="home">
+    Home
+  </a>,
+  <a href="#" key="page 1">
+    Page 1
+  </a>,
+  <a href="#" key="page 2">
+    Page 2
+  </a>,
+  <span key="current">Current page</span>,
 ];
 
 export const FourItems = () => {

diff --git a/docs/app/client/breadcrumb/examples/OneItem.tsx b/docs/app/client/breadcrumb/examples/OneItem.tsx
@@ -3,7 +3,7 @@
 import React from "react";
 import { Breadcrumb } from "@heathmont/moon-core-tw";
 
-const breadcrumbs = [<span>Current page</span>];
+const breadcrumbs = [<span key="current">Current page</span>];
 
 export const OneItem = () => {
   return <Breadcrumb breadcrumbs={breadcrumbs} />;

diff --git a/docs/app/client/breadcrumb/examples/TwoItems.tsx b/docs/app/client/breadcrumb/examples/TwoItems.tsx
@@ -3,7 +3,12 @@
 import React from "react";
 import { Breadcrumb } from "@heathmont/moon-core-tw";
 
-const breadcrumbs = [<a href="#">Home</a>, <span>Current page</span>];
+const breadcrumbs = [
+  <a href="#" key="home">
+    Home
+  </a>,
+  <span key="current">Current page</span>,
+];
 
 export const TwoItems = () => {
   return <Breadcrumb breadcrumbs={breadcrumbs} />;

diff --git a/docs/app/server/accordion/page.tsx b/docs/app/server/accordion/page.tsx
@@ -1,5 +1,4 @@
 import { PropsTable } from "@/components/propsTable";
-import { QuickNav } from "@/components/QuickNav";
 import { getExamples } from "@/utils/getExamples";
 import { MDX } from "@/components/MDX";
 import { ExampleSection } from "@/components/exampleSection/ExampleSection";
@@ -36,31 +35,31 @@ export default async function Accordion() {
         data={[
           {
             name: "itemSize",
-            type: "sm | md | lg | xl",
+            type: ["sm", "md", "lg", "xl"],
             defaultState: "md",
             description: "Size of accordion item",
           },
           {
             name: "singleOpen",
-            type: "boolean",
+            type: ["boolean"],
             defaultState: "false",
             description: "Whether only one item can be opened at a time",
           },
           {
             name: "defaultValue",
-            type: "string",
+            type: ["string"],
             defaultState: "-",
             description: "The value of the item to expand",
           },
           {
             name: "value",
-            type: "string[]",
+            type: ["string[]"],
             defaultState: "-",
             description: "The accordion items value",
           },
           {
             name: "onValueChange",
-            type: "(value: string[]) => void",
+            type: ["(value: string[]) => void"],
             defaultState: "-",
             description:
               "Event handler called when the expanded state of an item changes and prop singleOpen in false state",
@@ -72,13 +71,13 @@ export default async function Accordion() {
         data={[
           {
             name: "value",
-            type: "string",
+            type: ["string"],
             defaultState: "-",
             description: "The accordion item value",
           },
           {
             name: "disabled",
-            type: "boolean",
+            type: ["boolean"],
             defaultState: "false",
             description: "Set disabled/non-disabled",
           },

diff --git a/docs/app/server/button/page.tsx b/docs/app/server/button/page.tsx
@@ -37,61 +37,61 @@ export default async function Button() {
         data={[
           {
             name: "animation",
-            type: "'progress' | 'success' | 'error' | 'pulse' | boolean",
+            type: ["progress", "success", "error", "pulse"],
             defaultState: "-",
             description: "Animation of button",
           },
           {
             name: "as",
-            type: "a | button",
+            type: ["a , button"],
             defaultState: "button",
             description: "Rendered HTML element",
           },
           {
             name: "children",
-            type: "React.ReactNode",
+            type: ["React.ReactNode"],
             defaultState: "-",
             description: "Children content",
           },
           {
             name: "className",
-            type: "string",
+            type: ["string"],
             defaultState: "-",
             description: "Tailwind classes for customization",
           },
           {
             name: "disabled",
-            type: "boolean",
+            type: ["boolean"],
             defaultState: "false",
             description: "Disabled button",
           },
           {
             name: "fullWidth",
-            type: "boolean",
+            type: ["boolean"],
             defaultState: "false",
             description: "Full width button",
           },
           {
             name: "iconLeft",
-            type: "JSX.Element",
+            type: ["JSX.Element"],
             defaultState: "-",
             description: "Left icon",
           },
           {
             name: "iconRight",
-            type: "JSX.Element",
+            type: ["JSX.Element"],
             defaultState: "-",
             description: "Right icon",
           },
           {
             name: "size",
-            type: "xs | sm | md | lg | xl",
+            type: ["xs", "sm", "md", "lg", "xl"],
             defaultState: "md",
             description: "Size of button",
           },
           {
             name: "variant",
-            type: "fill | outline | ghost",
+            type: ["fill", "outline", "ghost"],
             defaultState: "fill",
             description: "Visual/Logical variant of button",
           },

diff --git a/docs/components/settings/Settings.tsx b/docs/components/settings/Settings.tsx
@@ -25,7 +25,7 @@ const Settings = () => {
   // Apply the current theme from localStorage when loaded
   useLayoutEffect(() => {
     apply();
-  }, []);
+  }, [apply]);
 
   return (
     <Popover