Do not fail workflow task if an error occurs when marking it as completed #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for a workflow task to fail to complete even during normal operation. For example, if a signal is added to the workflow history concurrently with a workflow task attempting to complete the workflow then the `RespondWorkflowTaskCompleted` call will recieve an `InvalidArgument` error with an `UnhandledCommand` cause. If this happens then the Ruby SDK would get this error and then try and fail the workflow task due to how the `rescue` block encompassed the completion function. This would then lead to the `RespondWorkflowTaskFailed` call failing because the server doesn't recognize the task anymore. This is because the task was actually finalized when the original `RespondWorkflowTaskCompleted` call was made and so it should not be interacted with anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a workflow task to fail to complete even during normal operation. For example, if a signal is added to the workflow history concurrently with a workflow task attempting to complete the workflow then the
RespondWorkflowTaskCompletedcall will recieve anInvalidArgumenterror with anUnhandledCommandcause.If this happens then the Ruby SDK would get this error and then try and fail the workflow task due to how the
rescueblock encompasses the completion function. This would then lead to theRespondWorkflowTaskFailedcall failing because the server doesn't recognize the task anymore. This is because the task was actually finalized when the originalRespondWorkflowTaskCompletedcall was made and so it should not be interacted with anymore.This PR catches the
RespondWorkflowTaskCompletederror sooner (similar to the query branch) so that it does not cause the workflow task to be failed and therefore avoids theWorkflow task not founderror from theRespondWorkflowTaskFailedcall. The error is still logged and passed to the error reporter though.