Deploy v1 Factory and Implementation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsoncusack
force-pushed
the
wilson/safe-deploy
branch
from
19102d9
to
9ad8a21
Compare
wilsoncusack
commented
Apr 23, 2024
| TestValidateUserOp:test_succeedsWithPasskeySigner() (gas: 785198) |
There was a problem hiding this comment.
These should have changed with #65 but there was a remapping resolving FreshCryptoLib incorrectly
|
There is a snapshot diff due to a fuzz tests. I think it is because the CI is using a different version of forge than I am able to access via vs. locally |
wilsoncusack
commented
Apr 23, 2024
| @@ -40,7 +40,7 @@ jobs: | |||
|
|
|||
| - name: Check snapshot | |||
| run: | | |||
| forge snapshot --check | |||
| forge snapshot --check --tolerance 1 | |||
There was a problem hiding this comment.
Let's find a better fix later for noisy fuzz tests
xenoliss
approved these changes
Apr 23, 2024
|
Review Error for xenoliss @ 2024-04-23 14:13:15 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.