Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toast component #1588

Merged
merged 18 commits into from
Nov 7, 2024
Merged

feat: toast component #1588

merged 18 commits into from
Nov 7, 2024

Conversation

brendan-defi
Copy link
Contributor

@brendan-defi brendan-defi commented Nov 5, 2024

What changed? Why?

  • created global component
  • refactored <SwapToast> and <TransactionToast> to use the global version
  • minor update to Swap types (state variables no longer optional, as they are defined within the provider)

Notes to reviewers

How has it been tested?
locally, in playground, and with full test coverage

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 7:15pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 7:15pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 7:15pm

src/swap/components/SwapToast.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@abcrane123 abcrane123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! agree with 5 second comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants