feat: add onConnect handler to <ConnectWallet />
#1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
October 24, 2024 12:22
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
reviewed
Oct 30, 2024
alessey
reviewed
Oct 30, 2024
cpcramer
approved these changes
Oct 30, 2024
0xAlec
approved these changes
Nov 1, 2024
dschlabach
changed the title
onInitialConnect handler to <ConnectWallet />onConnect handler to <ConnectWallet />
alessey
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
We're adding an
onConnecthandler to<ConnectWallet />so that developers can perform arbitrary actions after users click the "Connect Wallet" button. For example, this can be used to support SIWE without requiring a second button click/popup.While this can be done with wagmi today, this improves DX for devs who wan to perform an action only after a user clicks the
ConnectWalletbutton (vs. re-connecting on page reload/re-render).Notes to reviewers
How has it been tested?