Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Matching Functionality #41

Merged
merged 6 commits into from
May 28, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 28, 2020

Motivation

Fixes #38, #39, #40.

Solution

Return a new Match struct instead of *types.Operation from MatchOperations. This new struct allows for multiple *types.Operation to be matched with a given OperationDescription.

@patrick-ogrady patrick-ogrady changed the title [WIP] Improve Matching Functionality Improve Matching Functionality May 28, 2020
@coveralls
Copy link

coveralls commented May 28, 2020

Pull Request Test Coverage Report for Build 1563

  • 60 of 73 (82.19%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 65.93%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/match_operations.go 60 73 82.19%
Totals Coverage Status
Change from base Build 1501: 0.1%
Covered Lines: 1461
Relevant Lines: 2216

💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 94bd8ef into master May 28, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/support-repeated-descriptions branch May 28, 2020 14:43
This was linked to issues May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants