Indicate the current index when waiting to reach tip for check:construction
#370
Conversation
pkg/tester/construction.go
Outdated
| } | ||
|
|
||
| if atTip { | ||
| return blockIdentifier.Index, nil | ||
| return blockIdentifier.Index, 0, nil |
There was a problem hiding this comment.
Should this line be return blockIdentifier.Index, blockIdentifier.Index, nil? If the chain is at tip, I think it makes more sense the current index == tip index instead of current index == 0
| @@ -402,7 +402,7 @@ func (t *ConstructionTester) waitForTip(ctx context.Context) (int64, error) { | |||
| return tipIndex, nil | |||
| } | |||
|
|
|||
| log.Println("waiting for implementation to reach tip before testing...") | |||
| log.Printf("waiting for implementation to reach tip before testing... (current index: %d, tip delay: %d)\n", currentIndex, t.config.TipDelay) | |||
There was a problem hiding this comment.
I am thinking if we want to show the current sync status and progress, other than tip delay probably we can also add current block timestamp so that we know how far are we from the tip
There was a problem hiding this comment.
If I am not mistaken BlockIdentifier only has the hash and the index. We don't have the timestamp info to show, do we ?
|
I think this indication is useful for |
Motivation
When trying to run
check:constructionI was constantly getting thewaiting for implementation to reach tip before testing...message but couldn't tell if any progress was made. After a while I stopped it thinking I was stuck in a loop when I was just syncing super slowly.Solution
Add the current index and tip delay info to the message which show how we are progressing.
see