Use return() instead of exit() #183
Conversation
Previously, the function employed `exit()`, which, when invoked, results in the immediate termination of the entire program. In a library this is not a wanted response when handling errors, a better approach is to return an error code and let the calling application handle the error.
|
|
|
Good catch, this is certainly bad. Unfortunately, the error handling in this file doesn't seem to be too consistent. But this certainly doesn't make things worse. |
|
For this to make it into release, I'll need to cherry-pick it over into |
Thanks, it's appreciated. So far I have only found one more issue and that is the same flaw as was backported in CoinUtils, in coin-or/CoinUtils#217. I looked at the some of the other COIN-OR projects, they all have this same issue. |
|
Hmm, this is a bit mysterious. The patch was apparently in response to this issue: coin-or/CoinUtils#124. However, this patch alone wouldn't have fixed the issue, according to what you're saying. It should have then come up with the unit tests of other projects. Anyway, fixing them all seems like a good idea, but it may take a bit of time if I need to do it myself. |
Ok, i might have made it confusing by writing it in this PR. The issue I thought of is not related to this PR at all. |
|
Sorry @tkralphs I was a bit hasty, forget what I wrote here #183 (comment), I will make a separate issue. |
Previously, the function employed
exit(), which, when invoked, results in the immediate termination of the entire program. In a library this is not a wanted response when handling errors, a better approach is to return an error code and let the calling application handle the error.