Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HSL_MA97 headers for new version #646

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jfowkes
Copy link
Member

@jfowkes jfowkes commented Feb 13, 2023

Hi @svigerske

We're in the process of updating HSL_MA97 to v2.8.0 and in particular we have found an error in the reporting of the maximum front size statistic. This is being corrected to report the maximum number of rows in a supernode and the previously reported statistic is being reported as the maximum supernode size.

This has necessitated adding a new maxsupernode member to the ma97_info structs, using up one of the reserved integer spaces in the struct. As the info struct size remains the same I believe this change should be full backward compatible (earlier versions of HSL_MA97 will simply not have this entry set).

However, if you do think that this will be a breaking change, we are happy to drop it from the C interface.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

@svigerske
Copy link
Member

Doesn't sound like a breaking change. It also looks like is wouldn't make any change to Ipopt, since that int that gets renamed wasn't used and will probably not be used for now.

But it would be nice to not rename the struct. The Ipopt/MA97 interface assumes that it is always called ma97_info, whether building single or double precision.

@jfowkes
Copy link
Member Author

jfowkes commented Feb 13, 2023

Thank you for the input, actually the struct name does not change as it gets re-defined at the start of the header (Line 47) as has always been the case:

#define ma97_info ma97_info_d

along with all the other structs and functions (e.g. ma97_control_d). Naming the struct ma97_info despite the #define was fixed quite a while ago in v2.7.1 of HSL_MA97.

@svigerske
Copy link
Member

Ah yes. Thanks.

@svigerske svigerske merged commit 332132a into coin-or:stable/3.14 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants