-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DebugJournalistWrapper::jrnl_ used after being deleted #393
Comments
I am attaching a patch file IpIpoptApplication.txt that uses a kludge to fix the problem (see Kludge comments in patch file). Use the following commands to run the patch:
|
Thanks. So I went with your suggestion to have another (but smart) pointer to it in IpIpoptApplication. Pull request #396 should fix this. |
The exact same thing (header hell) happened me. Until someone figures out a better solution, |
- but accessible from IpoptApplication - calling SetJournalist from somewhere else is dangerous, so forbid for now (see #393)
I can even allow only the IpoptApplication to call it by making this a private function. |
Yes, in addition to the comment about who calls DebugJournalistWrapper::SetJournalist, it would be good to make the IpoptApplication class, or better yet its constructor, a friend of the DebugJournalistWrapper class and make the setting function private. I think that is what you are suggesting ? |
yes, I think that's what 1de2097 is doing. |
Yes. making the setting function private is a good idea. I think the line |
Na, it's fine. I'm afraid that I would have to include IpIpoptApplication.hpp if I do that. |
- but accessible from IpoptApplication - calling SetJournalist from somewhere else is dangerous, so forbid for now (see #393)
Fixed by #396. |
This bug shows up under the following conditions:
The following bash script verbosity_bug.sh (changed estension .sh -> .txt so github would upload it) demonstrates the bug:
verbosity_bug.txt
The text was updated successfully, but these errors were encountered: