-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document a workflow for investigating performance regressions. #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR makes sense to merge it once we are using package sync. Otherwise, there are a couple of things you need to tweak to be able to use it. Or we could temporarily document those tweaks, and then once the package sync PR is merged, remove them.
Thoughts?
I'll clarify some of the things you ran into. But I agree, this doesn't make much sense to merge until |
Co-authored-by: Naty Clementi <[email protected]>
Co-authored-by: Naty Clementi <[email protected]>
@ian-r-rose should we fix conflicts and get this one in since package sync is already in? |
Good point, I forgot about this one! Updating now... |
Okay, should be ready |
Thank you Ian! I'll wait for CI and then I'll merge it. |
Failures and regressions are known flaky and noisy repspectively. SInce this is purely docs I'll go ahead and merge it in. |
cc @hayesgb, who expressed some interest in this