Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Okio Proguard rule. #1837

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

kimhc999
Copy link
Contributor

@kimhc999 kimhc999 commented Aug 6, 2023

Okio removed the Proguard rule link from their document because they do not need it anymore.
square/okio#1290
square/okio#1304

The Okio Proguard rule link does not work anymore.
So we should remove it.

Copy link
Member

@colinrtwhite colinrtwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@colinrtwhite colinrtwhite merged commit 314a8cf into coil-kt:main Aug 8, 2023
5 checks passed
colinrtwhite added a commit that referenced this pull request Aug 10, 2023
* main:
  Bump androidx.benchmark:benchmark-macro-junit4 (#1841)
  Bump androidx.compose.ui:ui-test-junit4 from 1.4.3 to 1.5.0 (#1842)
  Bump compose from 1.4.3 to 1.5.0 (#1840)
  Disk cache load fails after 304 Not Modified when cached headers include non-ASCII characters (#1839)
  Remove the Okio Proguard rule. (#1837)
  Bump okio from 3.4.0 to 3.5.0 (#1836)
  Bump androidx.recyclerview:recyclerview from 1.3.0 to 1.3.1 (#1832)
  Bump androidx.benchmark:benchmark-macro-junit4 (#1831)
  Fix coil-benchmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants