Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): settings Menu UI going out of the viewer #4841

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

pramodcog
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4795

Description 📝

Setting Menu was going out of Viewer and causing unpleasant UX and some of the option were unselectable

SettingMenu-UI-Issue

Fixed
SeetingMenu-UI-Fixed

How has this been tested? 🔍

In 3D management subapp

Test instructions ℹ️

  • yalc link to fusion repo
  • run yalc add @cognite/reveal-react-components && yarn && nx serve 3d-management
  • Open any point-cloud model and from toolbar select Settings button

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog marked this pull request as ready for review November 1, 2024 16:20
@pramodcog pramodcog requested a review from a team as a code owner November 1, 2024 16:20
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pramodcog pramodcog enabled auto-merge (squash) November 4, 2024 08:54
@pramodcog pramodcog merged commit 5b99d8d into master Nov 4, 2024
14 checks passed
@pramodcog pramodcog deleted the pramodcog/BND3D-4795 branch November 4, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants