Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade API extractor to fix CI #3859

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Nov 1, 2023

Type of change

Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

npx api-extractor does not seem to work in a Linux environment with api-extractor version 7.38.1, but works in 7.38.0.

Tracking issue: microsoft/rushstack#4413

How has this been tested? 🔍

Locally, on my Linux machine.

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner November 1, 2023 13:06
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #3859 (e568515) into master (2ac2144) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3859   +/-   ##
=======================================
  Coverage   71.45%   71.46%           
=======================================
  Files         351      351           
  Lines       35085    35085           
  Branches     2671     2675    +4     
=======================================
+ Hits        25071    25073    +2     
+ Misses       9906     9904    -2     
  Partials      108      108           

see 1 file with indirect coverage changes

@haakonflatval-cognite haakonflatval-cognite merged commit cad6cf0 into master Nov 1, 2023
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/downgrade-api-extractor branch November 1, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants