fix: general cylinder inside rendering #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
added
the
slack
|
There were failures in the visual tests workflow. |
|
There were failures in the visual tests workflow. |
Codecov Report
@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 69.56% 69.57%
=======================================
Files 254 254
Lines 10348 10348
Branches 1331 1331
=======================================
+ Hits 7199 7200 +1
+ Misses 2980 2979 -1
Partials 169 169
|
christjt
requested changes
Oct 28, 2022
viewer/packages/rendering/src/glsl/sector/primitives/generalCylinder.vert
Outdated
Show resolved
Hide resolved
viewer/packages/rendering/src/glsl/sector/primitives/generalCylinder.vert
Show resolved
Hide resolved
christjt
approved these changes
Oct 31, 2022
haakonflatval-cognite
deleted the
hflatval/general-cylinder-inside-rendering
branch
christjt
pushed a commit
that referenced
this pull request
Nov 2, 2022
* fix: rendering if camera is inside primitive * fix: reverse normal direction if hitting inside of cylinder
christjt
added a commit
that referenced
this pull request
Nov 3, 2022
…ch (#2635) * chore: add workflow that deploys to NPM on Github release (#2586) * test: initial dry run publish * chore: trigger release on released published * fix: remove caching on release workflow Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: expose and fix bug causing getBoundingBoxByNodeId/TreeIndex not to modify out parameter (#2472) * refact: keyboard and mouse event handling in viewer (#2492) * Intermediate commit * Removed isFocused check in keyboard handling * Keyboard active only which domElement is focused, mouse events are active when canvas is focused * Refactored axisview eventlistener * Reverted axisview event passed to domElement * updated examples yarn.lock * clean up * leftover clean up * Keyboard event listen on domElement, removed unnecessary event push to domElement from Axis cross * removed unused variables * clean up * Fixed visual test error Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fixed point cloud picking precision issue (#2508) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * improvement: use 'high-performance' powerPreference to avoid non-discrete GPU being used on certain systems (#2512) * feat: add metrics to MeasurementTool (#2523) * chore: backport to old file structure * fix: remove flat modifier, while maintaining TreeIndex precision (#2536) Contribution by @Strepto (Equinor) * fix: do not blend in-front and back frame buffers when back objects have not been rendered (#2540) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: visualization artifacts due to wrongfully handling cylinder clip planes (#2556) * fix: simplify shader * fix: set proper plane length * fix: reduce some matrix transformations, and use built-in face-forward * fix: plane magnitude not adjusting for scaled world transform * fix: bad merge * chore: revert CDF environments json * chore: add primitive test fixture Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * improvement: make CadModelUpdateHandler trigger sector loading immediately after the camera stops moving (#2573) * Make CadModelUpdateHandler trigger sector loading immediately after the camera stops moving * Remove setting of redraw flag * Update test * Fix test Co-authored-by: Christopher J. Tannum <[email protected]> * Use vec2 instead of struct for packing TreeIndexes (#2585) This works around an issue with struct precision on ardeno gpus: KhronosGroup/WebGL#3351 * fix: general cylinder inside rendering (#2620) * fix: rendering if camera is inside primitive * fix: reverse normal direction if hitting inside of cylinder * fix: enable depth writing for in-front pass (#2621) * Enable depth writing for in-front pass * Set depth to minimum of in-front and back pass Co-authored-by: Christopher J. Tannum <[email protected]> * fix: remove unused pcMaterialManager from bad merge * fix: re-create v8 test image due to cylinder clipping planes fix Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Lars Moastuen <[email protected]> Co-authored-by: Pramod S <[email protected]> Co-authored-by: Nils Henrik Hals <[email protected]> Co-authored-by: eiriklegernaes <[email protected]> Co-authored-by: Håkon Flatval <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/REV-564
Description 📝
Fixes general cylinder when the camera is inside the cylinder. Also fixes the normal direction when looking at the inside of the cylinder.
How has this been tested? 🔍
By looking
Test instructions ℹ️
Have a good hard look
Checklist ☑️