Skip to content

Commit

Permalink
Test infra for py2.7 is broken. Drop it.
Browse files Browse the repository at this point in the history
We will no longer test packs with python2.7, as it is broken and the fix
(re-adding 2.7) is too invasive across all of our infrastructure.

We continue supporting 2.7 but only on an as-reported basis.
If someone submits a PR for 2.7 and it does not break with python 3, great.
If a pack is upgraded so that it can only be used with python 3,
then people can downgrade to an earlier version that supported python 2.

StackStorm/community#40 (comment)
  • Loading branch information
cognifloyd committed Jan 30, 2021
1 parent cd72fc9 commit d0f6a25
Showing 1 changed file with 17 additions and 51 deletions.
68 changes: 17 additions & 51 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,51 +60,6 @@ jobs:
steps:
- integration_test_with_zabbix

build_and_test_python27:
docker:
- image: circleci/python:2.7
- image: rabbitmq:3
- image: mongo:3.4

working_directory: ~/repo

environment:
VIRTUALENV_DIR: "~/virtualenv"
# Don't install various StackStorm dependencies which are already
# installed by CI again in the various check scripts
ST2_INSTALL_DEPS: "0"

steps:
- checkout
- restore_cache:
key: v1-dependency-cache-py27-{{ checksum "requirements.txt" }}
- run:
name: Download dependencies
command: |
git clone -b master git://github.com/stackstorm-exchange/ci.git ~/ci
~/ci/.circle/dependencies
- run:
name: Run tests (Python 2.7)
command: ~/ci/.circle/test
- save_cache:
key: v1-dependency-cache-py27-{{ checksum "requirements.txt" }}
paths:
- ~/.cache/pip
- ~/.apt-cache
# NOTE: We use virtualenv files from Python 2.7 step in "deploy" job so we
# only persist paths from this job
- persist_to_workspace:
root: /
paths:
- home/circleci/ci
- home/circleci/virtualenv
- tmp/st2
- home/circleci/repo
- home/circleci/.gitconfig

# NOTE: Until we add "python_version" metadata attribute to pack.yaml and
# explicitly call which packs work with Python 3.x, Python 3.x failures are
# not considered fatal
build_and_test_python36:
docker:
- image: circleci/python:3.6
Expand Down Expand Up @@ -146,10 +101,21 @@ jobs:
paths:
- ~/.cache/pip
- ~/.apt-cache
# NOTE: We use virtualenv files from Python 3.6 step in "deploy" job so we
# only persist paths from this job
- persist_to_workspace:
root: /
paths:
- home/circleci/ci
- home/circleci/virtualenv
- tmp/st2
- home/circleci/repo
- home/circleci/.gitconfig


deploy:
docker:
- image: circleci/python:2.7
- image: circleci/python:3.6

working_directory: ~/repo

Expand All @@ -159,7 +125,7 @@ jobs:
steps:
- checkout
- restore_cache:
key: v1-dependency-cache-py27-{{ checksum "requirements.txt" }}
key: v1-dependency-cache-py36-{{ checksum "requirements.txt" }}
- attach_workspace:
at: /
- run:
Expand All @@ -168,8 +134,11 @@ jobs:
sudo apt-get update
sudo apt -y install gmic optipng
- run:
# NOTE: We try to retry the script up to 5 times if it fails. The command could fail due
# to the race (e.g. we try to push changes to index, but index has been updated by some
# other pack in the mean time)
name: Update exchange.stackstorm.org
command: ~/ci/.circle/deployment
command: ~/ci/.circle/retry_on_failure.sh ~/ci/.circle/deployment

workflows:
version: 2
Expand All @@ -178,11 +147,9 @@ workflows:
jobs:
- integration_test_with_zabbix_32
- integration_test_with_zabbix_40
- build_and_test_python27
- build_and_test_python36
- deploy:
requires:
- build_and_test_python27
- build_and_test_python36
- integration_test_with_zabbix_32
- integration_test_with_zabbix_40
Expand All @@ -191,7 +158,6 @@ workflows:
only: master
build_test_weekly:
jobs:
- build_and_test_python27
- build_and_test_python36
# Workflow which runs nightly - note we don't perform deploy job on nightly
# build
Expand Down

0 comments on commit d0f6a25

Please sign in to comment.