forward dataset statistics to ImageClass #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Oct 3, 2022
vincentsarago
commented
Oct 3, 2022
| for prod in itertools.product(*stats): # type: ignore | ||
| res.append(apply_expression(blocks, self.band_names, numpy.array(prod))) | ||
|
|
||
| stats = list(zip([min(r) for r in zip(*res)], [max(r) for r in zip(*res)])) |
There was a problem hiding this comment.
This is the only real interesting part of the addition (because technically you can access the metadata directly with rasterio). Here we calculate the result of the expression on the min/max values so we get the min/max of the expression output
vincentsarago
commented
Oct 3, 2022
rio_tiler/reader.py
Outdated
| stat_min = float(tags.get("STATISTICS_MINIMUM")) | ||
| stat_max = float(tags.get("STATISTICS_MAXIMUM")) | ||
|
|
||
| dataset_statistics.append((stat_min, stat_max)) |
There was a problem hiding this comment.
we only add dataset_statistics if all the bands have it
vincentsarago
commented
Oct 4, 2022
| @@ -473,7 +498,7 @@ def render( | |||
| kwargs.update({"crs": self.crs}) | |||
|
|
|||
| data = self.data.copy() | |||
| datatype_range = (dtype_ranges[str(data.dtype)],) | |||
| datatype_range = self.dataset_statistics or (dtype_ranges[str(data.dtype)],) | |||
There was a problem hiding this comment.
if present we use the dataset min/max for the auto rescaling!
vincentsarago
added a commit
that referenced
this pull request
Oct 19, 2022
* update rasterio requirement (#517) * update rasterio requirement * remove python 3.7 * update changelog * reader functions returns ImageData object (#515) * reader functions returns ImageData object * update changelog * remove async base reader (#520) * remove gcp reader (#521) Co-authored-by: vincentsarago <[email protected]> * avoid warning in tests * generalize buffer option (#519) * generalize buffer option * refactor buffer calculation * better tests * remove min/max zoom from baseclass attribute (#522) * remove min/max zoom from baseclass attribute * fix benchmark * split zooms methods and add tests * rename function * move apply_expression into ImageData class and use `b{ix}` for band names (#523) * move apply_expression into ImageData class and use `b{ix}` for band names * fix test * make sure we have the good number of bands * Apply expression part2 (#525) * ImageData.apply_expression return a new ImageData object * refactor Points method and deprecate asset_expression * remove unused option * Update rio_tiler/models.py * fix regex * add PointData class (#526) * add PointData class * fix test * remove deprecated * fix test 2 * better expression parsing for stac * docstring fixes * only use WarpedVRT when doing reprojection or nodata overwride (#529) * update baseclass to remove useless kwargs * update changelog * forward dataset statistics to ImageClass (#531) * forward dataset statistics to ImageClass * better type and autorescale * one more test * rename `COGReader` to `Reader` and remove relative import (#534) * rename COGReader to Reader and remove relative import * rasterio * debug * merge from branch * add note for backwards compatibility of COGReader * remove individual options attributes (#535) * remove individual options attributes * add typeDict for options * allow empty options * make sure to not change the input array * add ImageReader for non-geo images (#536) * add ImageReader for non-geo images * update changelog * Xarray reader (#530) * sketch out Xarray support * Update rio_tiler/io/xarray.py Co-authored-by: Ryan Abernathey <[email protected]> * read tile * assume crs is in the dataset * upside down * dependencies * cleanup * add more methods and cleanup * Update rio_tiler/io/xarray.py Co-authored-by: Tom Augspurger <[email protected]> * enumerate from 1 * fix * add dataset_statistics and notebook * add XarrayReader in top level import * add tests * update notebook * update changelog Co-authored-by: Ryan Abernathey <[email protected]> Co-authored-by: Tom Augspurger <[email protected]> * add migration docs * update readme * update notebooks * update docs Co-authored-by: Jeff Albrecht <[email protected]> Co-authored-by: Ryan Abernathey <[email protected]> Co-authored-by: Tom Augspurger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #488