switch to pyproject.toml #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Apr 8, 2022
| indexes=asset_indexes.get(asset, kwargs.pop("indexes", None)), | ||
| expression=asset_expression.get(asset), | ||
| indexes=asset_indexes.get(asset, kwargs.pop("indexes", None)), # type: ignore | ||
| expression=asset_expression.get(asset), # type: ignore |
There was a problem hiding this comment.
I don't fully understand why mypy doesn't pickup asset_indexes = asset_indexes or {} at L440 🤷♂️
vincentsarago
commented
Apr 8, 2022
| @@ -416,7 +416,7 @@ def part( | |||
| **kwargs, | |||
| ) | |||
|
|
|||
| if expression: | |||
| if expression and indexes: | |||
There was a problem hiding this comment.
indexes will always be defined when using expression because we create indexes from expression at L402. adding and indexes just makes mypy happy
vincentsarago
commented
Apr 8, 2022
| band_names: Optional[List[str]] = None | ||
| crs: Optional[CRS] | ||
| bounds: Optional[BBox] | ||
| band_names: List[str] |
|
Using my admin power to merge this PR. Comment are still welcome but so far we didn't received any negative feedback for moving rio-cogeo/rio-viz to pyproject.toml/flit. Typing issue could be resolved on other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
tox