-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS_HTTPS support + fix missing scheme #476
Conversation
@emmanuelmathot I'm not quite sure we should use I'm not sure of this but in theory a STAC url could need an S3 endpoint while the asset could not 🤷 |
Co-authored-by: Vincent Sarago <[email protected]>
I agree with a more dedicated solution for S3 config. I came up with this pragmatic one to make it work seamlessly with GDAL config. |
ok lets go ahead with what you propose. Later we could add another variable if a user need to have different endpoints for the item and assets |
Proposed Changes:
This PR add support for setting the S3 endpoint url scheme via the
AWS_HTTPS
environment variables inaws_get_object
function using boto3. AWS_HTTPS is aligned on on gdal vsis3 implmenation: https://github.com/OSGeo/gdal/blob/12aaf4be2c20a399efe005482e811a579a12a9fb/port/cpl_aws.cpp#L1207PR Checklist:
tox
)