-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Goal scripting language, in Code, Numbers, Author. #355
base: main
Are you sure you want to change the base?
Conversation
… 'go build' if it finds a 'goal' exe on path.
…ough launchctl as documented in README.md and implemented in goal
```sh | ||
launchctl setenv VAR VALUE | ||
``` | ||
The `goal` shell automatically does this for you when setting any environment variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user sets an environment variable in the interactive shell, there is absolutely no way that they expect it to make changes to the underlying system environment. At the very least this should only apply to things in the .goal
file, given that I could do set A test
or something in the interactive shell while experimenting, and I absolutely would not want that stored in the system forever!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, designing a system that is wholly incompatible with most people's shells is not tenable. Cogent Code must support someone who uses bash and wants to be able to run commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about just running all commands through separate Goal processes in Cogent Code, which would bypass the environment variable issue entirely since Goal would get the right environment variables on startup? We will be replacing a lot of the current command infrastructure with a Goal terminal interface soon anyway.
Several key fixes so Goal treats generated files appropriately (read only) and looks for the source of such files and opens them instead, etc.