Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problem that when the number inside the region
changes, the end of the region might also changes.
For example, when the region contains "9 10", first we will increase 9 to 10, then the region end is changed. Actually the Emacs would issue an error: "Invalid search bound (wrong side of point)" in this case. Using narrow-to-region can avoid such problem.
By the way, I think it is better to remove the
deactivate-mark
in the code for the region. If we do that, the region is still active after we doevil-numbers/inc-at-pt
orevil-numbers/dec-at-pt
, so we can repeatedly increase/decrease the numbers in the region, and we can also do some other things for the region(copy, kill, etc.). Right now the user has to reselect the region after they useevil-numbers/inc-at-pt
orevil-numbers/dec-at-pt
. But this is only my personal favor, and I didn't include this change in this pull request. You decide. :-)