Directory separator and its duplicates

[BrianHenryIE]

Fix for #90 , #43.

The meat in this is trim(preg_replace('/[\/\\\\]+/', DIRECTORY_SEPARATOR, $path), DIRECTORY_SEPARATOR) which is run on every variable in Mover::moveFile() that is to be used in a file path. The provides Windows <-> Unix compatibility and by always trimming the slashes, makes it easier to reason inside the code. $workingDir is the only variable with a leading slash, since it is the absolute path and all others are relative.

No tests written, but existing tests are fine. Marking it as draft for a few weeks while I test it in production!

Two integration tests added.

[BrianHenryIE]

I think this relies on #91 : Requires #91 for #90 to work, but this PR does not build on #91.

The test for #90 will not pass until #91 is merged.

[BrianHenryIE]

It would be great if someone on Windows could test this.

git clone https://github.com/coenjacobs/mozart.git
git remote add brianhenryie git://github.com/brianhenryie/mozart.git
git fetch brianhenryie
git merge brianhenryie/move-files-once-per-autoloader
git merge brianhenryie/DIRECTORY_SEPARATOR-and-its-duplicates
composer install
composer run-script test

I just realised the tests will fail for the same reason we needed DIRECTORY_SEPARATOR!

[BrianHenryIE]

This looks good with master merged into it and tested on MacOS and on Windows 10 w/ PHP 7.4.

It was on a pretty fresh VM on Parallels so needed:

• Installing PHP 7 and Composer on Windows 10, Natively
• Download Composer
• Getting Started - Installing Git

Interestingly, "DIRECTORY_SEPARATOR is not necessarily needed, PHP always converts / to the appropriate character in its file functions."

To run the tests, I needed.

php vendor\phpunit\phpunit\phpunit

It's failing with PHP 8 in GitHub Actions.