Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually fixed readFile (windows) #225

Closed
wants to merge 2 commits into from
Closed

actually fixed readFile (windows) #225

wants to merge 2 commits into from

Conversation

Silviu-Marian
Copy link
Contributor

@Silviu-Marian Silviu-Marian commented Feb 25, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Refactoring (no functional changes, no api changes)

What is the current behavior? (You can also link to an open issue here)
The fix in #208 (#69, #40) didn't work. When creating new files that match the globbing pattern in karma.config, the watcher crashes and needs a manual restart.

What is the new behavior?
Watcher doesn't crash when creating new files :)

Does this PR introduce a breaking change?

  • No

Other information:
Tried to wrap my head around the contributing guide, but ran into problems. If you need me to update anything please let me know.

@jsf-clabot
Copy link

jsf-clabot commented Feb 25, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Silviu-Marian
❌ Silviu Marian


Silviu Marian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@joshwiens
Copy link
Contributor

@Silviu-Marian - Having seen more than a few email issues with the CLA, my advice would be to ensure your local git config matches the email in github then on a completely new branch, add the code mods and commit again. Close this PR, open a new one.

The multiple versions of you thing isn't something you will be able to resolve in this pull request / branch.

@Silviu-Marian
Copy link
Contributor Author

Hello :) My work e-mail was stuck in the config
Sorry for the trouble. I'll close this one and open another one

Thanks for letting me know

@Silviu-Marian Silviu-Marian mentioned this pull request Feb 25, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants