Added support for multiple character separators at string humanizer #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| class Humanize | |||
| { | |||
| const SEPARATOR_DASH = '-'; | |||
| const SEPARATOR_UNDERSCORE = '_'; | |||
There was a problem hiding this comment.
I dont think we really need those constants.
public function __construct($text, $capitalize = true, $separator = '-')
should be enough. In next release I would like to change this behavior anyway, I would like to not pass aything by default as a separator.
There was a problem hiding this comment.
Agreed. Just making the change and we will be good to go.
|
@drgomesp thanks a lot! Please take a look at my comment and I gonna merge it. |
norberttech
pushed a commit
that referenced
this pull request
Nov 1, 2015
…ator Added support for multiple character separators at string humanizer
|
@drgomesp thanks! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #45, now you can pass a special character separator to humanize strings: