use breakpoints and grid_columns field settings over global settings #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
While playing with your great package I stumbled upon what I believe is a bug. I fixed some of it in this PR (at least it behaves better locally) but I am pretty sure there could be more I haven't fixed.
The basic issue is not using the
breakpointsandgrid_columnssettings fromPictureFieldin the{% picture %}templatetag and related utilities. Instead the global settings are always used. If I understand the intention of the code correctly that is not supposed to happen.I still import settings to make the unit tests work, I am sure you have a better way of doing that, feel free to edit.
Let me know if you have questions 👍