Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BaseConnection] fix edge.cursor mismatch. #32

Closed
thenamankumar opened this issue May 15, 2020 · 7 comments · Fixed by #139
Closed

[BaseConnection] fix edge.cursor mismatch. #32

thenamankumar opened this issue May 15, 2020 · 7 comments · Fixed by #139

Comments

@thenamankumar
Copy link
Contributor

The cursor for each node generated by the BaseConnection does not match with the start and end cursors generated by Sequelize Pagination.

Check the implementation of the package and replicate/fix the logic of generating cursor in the BaseConnection to match the start and end cursors.

@bharath-123
Copy link

bharath-123 commented May 15, 2020

Hey I would like to work on this. I am beginning work on this.

@bharath-123
Copy link

How can I go about reproducing this issue?

@thenamankumar
Copy link
Contributor Author

For reproducing the issue, make the following query using the graphql playground at `localhost:3000/api/graphql

users {
  edges {
    node {
      id
    }
    cursor
  }
  pageInfo {
    startCursor
    endCursor
  }
}

You will see that the startCursor won't be same at edges[0].cursor and edges[<last_index].cursor won't be same as endCursor.

@coderrsid
Copy link
Contributor

coderrsid commented May 18, 2020

I don't have oneauth local setup, i am using ONEAUTH_CLIENT_ID, ONEAUTH_CLIENT_SECRET by creating the instance by second method in my env file
image

@jugshaurya
Copy link
Contributor

jugshaurya commented Jun 10, 2020

@hereisnaman, users are coming to be null even if I have seeded the users? can u tell me why?
should I pass some headers?

c

e

User table data: -
d

Also working on this issue

@thenamankumar
Copy link
Contributor Author

@jugshaurya try setting withCredentials as true in the gql playground settings.

@jugshaurya
Copy link
Contributor

@jugshaurya try setting withCredentials as true in the gql playground settings.

yes, that worked thanks. Working on the issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants