Fix pipeline validate method (required schema when template is present) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boscard
approved these changes
Jun 15, 2020
| @@ -124,8 +124,7 @@ func (p Pipeline) validate(localData map[string]interface{}) error { | |||
| // template is optional key, but it requires defined schema | |||
There was a problem hiding this comment.
I believe that this comment is not valid anymore :)
There was a problem hiding this comment.
Why? When template key is present, a defined schema is required
boscard
pushed a commit
that referenced
this pull request
Jun 15, 2020
…t) (#107) * Fix pipeline validate method (required schema when template is present) * Add example v2 pipeline
boscard
pushed a commit
that referenced
this pull request
Jun 15, 2020
…t) (#107) * Fix pipeline validate method (required schema when template is present) * Add example v2 pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.