Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

Server optimizations #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Server optimizations #81

wants to merge 3 commits into from

Conversation

picimako
Copy link
Contributor

@picimako picimako commented Mar 7, 2023

Changes

  • Removed the capability check for textDocument/publishDiagnostics for multiple reasons
    • diagnostics is the fundamental feature of the Rosie Language Server, so integration in a client that doesn't support diagnostics wouldn't make much sense
    • Eclipse IDE sends false for the textDocument/publishDiagnostics capability, so we cannot rely safely on that.
  • Prepared the server to be able to compute TextEdits in onCodeAction() in case the client doesn't support codeAction/resolve. This is partially the case for Eclipse, that announces this capability incorrectly due to a bug on their side. The related flag can be used to handle such cases as well.
  • Added support to retrieve the Codiga API Token configuration as codigaApiToken besides codiga.api.token. This is useful at least in the case of e.g Java implementations, where creating nested objects is more cumbersome than in other languages like JS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant