Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.29.x] Improve query metrics logging #6822

Closed
wants to merge 1 commit into from

Conversation

zkirksey
Copy link
Collaborator

What does this PR do?

Adds a few additional metrics to the existing query metric functionality and defines process for logging these metrics. In order to enable metric logging, the metrics-enabled property must be set to true on the query's request or response properties. In addition, additional metrics can be added to the log statement by adding a map to request or response properties via additional-query-metrics.

Who is reviewing it?

Select relevant component teams:

Ask 2 committers to review/merge the PR and tag them here.

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

Added additional query metrics

Small bug fix

Improved query metrics logging

Adding new timing metrics

Addressing comments

Removed unused metrics

Cleaned up more unused code
@zkirksey
Copy link
Collaborator Author

build now

@cxbot
Copy link

cxbot commented Dec 11, 2024

Can one of the admins verify this patch?

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jlcsmith jlcsmith changed the title Improve query metrics logging [2.29.x] Improve query metrics logging Dec 11, 2024
@zkirksey
Copy link
Collaborator Author

closed for #6823

@zkirksey zkirksey closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants