[2.29.x] More upgrades based on karaf upgrade #6821
+169
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenhein
force-pushed
the
more-upgrades-based-on-karaf-upgrade
branch
from
6149c95 to
8d785f0
Compare
jlcsmith
reviewed
Dec 9, 2024
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
jlcsmith
changed the title
|
fyi: local full build passes |
zkirksey
reviewed
Dec 16, 2024
| <artifactId>gt-jts-wrapper</artifactId> | ||
| <version>${org.geotools.version}</version> | ||
| </dependency> | ||
| <!-- <dependency>--> |
There was a problem hiding this comment.
It seems that gt-jts-wrapper was commented out in a few different pom files, but never removed.
| <quartz.version>2.3.2</quartz.version> | ||
| <require-css.version>0.1.10</require-css.version> | ||
| <sardine.version>5.7</sardine.version> | ||
| <!-- <hazelcast.version>5.1.7</hazelcast.version>--> |
There was a problem hiding this comment.
Seems this comment can be removed
| @@ -233,7 +237,7 @@ | |||
| <bundle>wrap:mvn:org.geotools/gt-opengis/${org.geotools.version}$Bundle-Name=gt-opengis&Bundle-SymbolicName=gt-opengis</bundle> | |||
| <bundle>wrap:mvn:org.geotools/gt-main/${org.geotools.version}$Bundle-Name=gt-main&Bundle-SymbolicName=gt-main</bundle> | |||
| <bundle>wrap:mvn:org.geotools/gt-cql/${org.geotools.version}$Bundle-Name=gt-cql&Bundle-SymbolicName=gt-cql</bundle> | |||
| <bundle>wrap:mvn:org.geotools/gt-jts-wrapper/${org.geotools.version}$Bundle-Name=gt-jts-wrapper&Bundle-SymbolicName=gt-jts-wrapper</bundle> | |||
| <bundle>wrap:mvn:org.geotools/gt-jts-wrapper/24.7$Bundle-Name=gt-jts-wrapper&Bundle-SymbolicName=gt-jts-wrapper</bundle> | |||
There was a problem hiding this comment.
Maybe we should make a new version declaration in the root pom in case we would like to update the version of this dependency in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Who is reviewing it?
Select relevant component teams:
Ask 2 committers to review/merge the PR and tag them here.
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes: #____
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: