Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-5606 Standardized references to 'resources' in documentation #5608

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

ricklarsen
Copy link

What does this PR do?

Changes, where possible, references to 'data products' to the more accurate 'data resources' or simply 'resources'

Select relevant component teams:

@codice/data
@codice/docs

Ask 2 committers to review/merge the PR and tag them here.

@ahoffer
@brendan-hofmann
@brjeter
@clockard
@lessarderic
@mcalcote
@pklinef
@ricklarsen - Documentation
@shaundmorris

How should this be tested?

review content

Any background context you want to provide?

Tried not to change references where the actual code being referenced uses the term 'product' instead of 'resource'

What are the relevant tickets?

Fixes: #5606

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@ricklarsen ricklarsen self-assigned this Nov 20, 2019
@ricklarsen ricklarsen added 📖 Documentation docs-content Draft or revise documentation content 👞Bug Fix labels Nov 20, 2019
@ricklarsen ricklarsen added this to the 2.22.0 milestone Nov 20, 2019
@@ -165,8 +165,8 @@ It is possible to have only remote Sources configured and no local `CatalogProvi

===== Product Retrieval

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✏️ I noticed Product Caching seems to be different, but I wasn't sure about these (166, 171, 172)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change any of the configurations (metatypes, for example) under the scope of this PR and they use "Product"

Copy link
Contributor

@ahoffer ahoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Big change. Thanks Rick and co.!

It is possible to retrieve products from specific remote Sources by specifying the site name(s) in the request.
The `CatalogFramework` relies on the Sources to execute the actual resource retrieval.
Optional `PreResource` and `PostResource` Catalog Plugins may be invoked by the `CatalogFramework` to modify the resource retrieval request/response prior to the Catalog Provider processing the request and providing the response.
It is possible to retrieve resources from specific remote Sources by specifying the site name(s) in the request.

.Product Caching
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Should all of the "Product" headers (Product Retrieval, Product Retrieval Services, Product Cacheing, etc.) be changed to "Resource" as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configurations for these in the code use Product, so I left them for now, but it'd be nice to change them up as well

. Select *Configuration*.
. Select *Resource Download Settings*.

See <<{reference-prefix}ddf.catalog.resource.download.ReliableResourceDownloadManager,Resource Download Settings configurations>> for all possible configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Can you explain?

@ricklarsen
Copy link
Author

build now

@cxbot
Copy link

cxbot commented Dec 2, 2019

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Dec 2, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/7771/
✅ JOB SUCCESS

@ricklarsen ricklarsen merged commit 4d3c26f into codice:master Dec 2, 2019
@ricklarsen ricklarsen deleted the DDF-5606-master branch December 2, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Documentation 👞Bug Fix docs-content Draft or revise documentation content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize terminology for "resources" in documentation
7 participants