Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separated GitHub actions #69

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Separated GitHub actions #69

merged 9 commits into from
Oct 31, 2023

Conversation

kloV148
Copy link
Contributor

@kloV148 kloV148 commented Oct 24, 2023

Separated eslint check action and build action

@kloV148
Copy link
Contributor Author

kloV148 commented Oct 24, 2023

Added:

  • Action to build app (runs when PR open/changed or push to main)
  • Action to run eslint check (runs when PR open/changed or push to main)
  • Action to deploy app (runs only when push to main)

Removed:

  • Action Build and push docker image (now it's run eslint check + deploy WEB)

@kloV148
Copy link
Contributor Author

kloV148 commented Oct 30, 2023

Fixed: Checks don't run when pushing to pull request (added synchronize trigger)

GoldenJaden
GoldenJaden approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@GoldenJaden GoldenJaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@GoldenJaden GoldenJaden merged commit 65be293 into codex-team:main Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoldenJaden GoldenJaden GoldenJaden approved these changes

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kloV148 @neSpecc @GoldenJaden