Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Button to Logout in Settings #68

Merged
merged 8 commits into from
Nov 23, 2023
Merged

Added Button to Logout in Settings #68

merged 8 commits into from
Nov 23, 2023

Conversation

shvkhzod
Copy link
Member

@shvkhzod shvkhzod commented Oct 23, 2023 •
edited
Loading

  • Changed useOAuth.ts to useAuth.ts
  • Created AuthLogoutEvent to notify other listeners about the logout
  • Added removeUser method to user.repository to clear the user data once user logs out
  • Added word logout to en.json

@slaveeks
Copy link
Member

Fix code style, you have a lot of unnecessary blank lines

@shvkhzod shvkhzod requested a review from neSpecc October 27, 2023 15:55
@shvkhzod
-Renamed the useOAuth to useAuth
a406f39 
-Added authService logout function to useAuth
-Deleted Logout Button Component and used only Button Component
- Used authService methods from useAuth
- Used i18n to display text in button
neSpecc
neSpecc reviewed Nov 1, 2023
View reviewed changes
src/application/services/useAuth.ts Outdated Show resolved Hide resolved
src/presentation/pages/Settings.vue Outdated Show resolved Hide resolved
@shvkhzod shvkhzod requested a review from neSpecc November 5, 2023 19:05
neSpecc
neSpecc reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to unauthorise NotesApiTransport instance, check infrastructure/index.ts.

There is also one suggestion left. Check Files Changed page.

@shvkhzod
- Added eventListener in notesApiTransport
fbecec9 
- Changed the name of the function to logout
@neSpecc
Copy link
Member

neSpecc commented Nov 7, 2023

Please, update a branch

@medvalna medvalna self-requested a review November 23, 2023 14:02
@shvkhzod shvkhzod merged commit 0dfeb4a into codex-team:main Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medvalna medvalna medvalna approved these changes

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shvkhzod @slaveeks @neSpecc @medvalna