Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response schema to all API methods #247

Merged
merged 17 commits into from
Apr 29, 2024
Merged

Add response schema to all API methods #247

merged 17 commits into from
Apr 29, 2024

Conversation

iamgabrielsoft
Copy link
Contributor

@iamgabrielsoft iamgabrielsoft commented Apr 11, 2024 •
edited
Loading

Add Fastify schema rules to each route, for request and response handling (issue of #181)

@iamgabrielsoft iamgabrielsoft self-assigned this Apr 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.65% (🎯 80%)
⬆️ +0.33%		 7777 / 8975
🟢 Statements 86.65% (🎯 80%)
⬆️ +0.33%		 7777 / 8975
🔴 Functions 79.47% (🎯 80%)
⬇️ -0.85%		 244 / 307
🟢 Branches 85.84% (🎯 80%)
⬇️ -0.51%		 370 / 431
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/presentation/http/http-api.ts 96.1% 90.32% 93.75% 96.1% 105-113, 125-126, 326-327, 351-352
src/presentation/http/router/auth.ts 96.15% 100% 100% 96.15% 121-125
src/presentation/http/router/note.ts 98.17% 82.6% 100% 98.17% 145-146, 558-559, 575-581
src/presentation/http/router/noteList.ts 100% 100% 100% 100%
src/presentation/http/router/noteSettings.ts 98.94% 85.71% 100% 98.94% 211-212, 273-274
src/presentation/http/router/oauth.ts 59.55% 100% 100% 59.55% 49-84
src/presentation/http/router/upload.ts 78.06% 100% 100% 78.06% 86-112, 143-149
src/presentation/http/router/user.ts 89.94% 75% 100% 89.94% 58-59, 93-99, 183-193
src/presentation/http/schema/Join.ts 100% 100% 100% 100%
src/presentation/http/schema/NoteSettings.ts 100% 100% 100% 100%
src/presentation/http/schema/OauthSchema.ts 100% 100% 100% 100%
Generated in workflow #719

@iamgabrielsoft iamgabrielsoft mentioned this pull request Apr 11, 2024
Closed
elizachi
elizachi requested changes Apr 15, 2024
View reviewed changes
src/presentation/http/router/auth.ts Outdated Show resolved Hide resolved
src/presentation/http/router/auth.ts Show resolved Hide resolved
src/presentation/http/router/auth.ts Show resolved Hide resolved
src/presentation/http/router/oauth.ts Outdated Show resolved Hide resolved
src/presentation/http/router/oauth.ts Outdated Show resolved Hide resolved
src/presentation/http/router/upload.ts Outdated Show resolved Hide resolved
neSpecc
neSpecc requested changes Apr 22, 2024
View reviewed changes
src/presentation/http/router/auth.ts Outdated Show resolved Hide resolved
src/presentation/http/router/note.ts Show resolved Hide resolved
src/presentation/http/router/noteSettings.ts Show resolved Hide resolved
src/presentation/http/router/noteSettings.ts Show resolved Hide resolved
src/presentation/http/router/oauth.ts Outdated Show resolved Hide resolved
src/presentation/http/schema/OauthSchema.ts Show resolved Hide resolved
src/presentation/http/schema/User.ts Outdated Show resolved Hide resolved
elizachi
elizachi reviewed Apr 24, 2024
View reviewed changes
.eslintrc.cjs Outdated Show resolved Hide resolved
neSpecc
neSpecc requested changes Apr 24, 2024
View reviewed changes
src/presentation/http/router/note.ts Outdated Show resolved Hide resolved
src/presentation/http/router/noteSettings.ts Outdated Show resolved Hide resolved
src/presentation/http/router/noteSettings.ts Show resolved Hide resolved
neSpecc
neSpecc requested changes Apr 26, 2024
View reviewed changes
src/presentation/http/router/noteSettings.ts Outdated Show resolved Hide resolved
src/presentation/http/router/noteSettings.ts Show resolved Hide resolved
src/presentation/http/router/note.ts Show resolved Hide resolved
@TatianaFomina
Copy link
Contributor

Please, merge this PR

@iamgabrielsoft iamgabrielsoft merged commit f4da7b3 into main Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizachi elizachi elizachi approved these changes

@TatianaFomina TatianaFomina TatianaFomina approved these changes

@neSpecc neSpecc neSpecc approved these changes

@slaveeks slaveeks Awaiting requested review from slaveeks

Assignees

@iamgabrielsoft iamgabrielsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamgabrielsoft @TatianaFomina @neSpecc @elizachi