Feat (Conversion-config): pass target tool config to the conversionConfig.import method #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now `convertStringToBlockData` method passes target tool config the import method - Fixed types in convesion config file (somehow imprort could return function that returns string, but import should return method that would return ToolData) this caused just type error that never been reached because types were actually ignored - Added test that checks, that import method actualy gets passed config
e11sy
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
neSpecc
requested changes
Oct 16, 2024
neSpecc
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In some tools (for example
nested-list), tool config should be respected on conversion, but this functionality was unreachable since config is passed to the tool in constructor andconversionConfigisstaticand not related to the tool instanceSolution
Pass target tool config on the
conversionConfig.importmethod inside of the EditorBlockManagerChanges
convertStringToBlockDatamethod passes target tool config the import method