fix(inline-toolbar): editor element grow on inline toolbar close #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested review from
gohabereg,
TatianaFomina and
ilyamore88
as code owners
ilyamore88
approved these changes
Oct 18, 2023
gohabereg
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users meets a bug:
When Inline Toolbar closes, wrapper element grows down. See a grey zone below editor — it appears when Inline Toolbar left and top becomes "unset".
That happened because Inline Toolbar inserted below the blocks-wrapper, so "unset" returns it to the DOM-based position: below the editor. And since the Inline Toolbar has height, browser somewhy expands a wrapper.
As a solution, we can reset Inline Toolbar coords by "0" instead of "unset". So hidden Inline Toolbar will be placed at top-left corner of editor.