Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the leak of codex-tooltip when Editor.js is destroyed #1590

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Prevent the leak of codex-tooltip when Editor.js is destroyed #1590

merged 2 commits into from
Apr 14, 2021

Conversation

hata6502
Copy link
Contributor

@hata6502
Copy link
Contributor Author

Resolved the conflicts.

@gohabereg
Copy link
Member

Hi @hata6502
Could you please resolve conflicts, we'd like to merge this one

@hata6502
Copy link
Contributor Author

hata6502 commented Apr 8, 2021 •
edited
Loading

Resolved!🚀

@gohabereg
Copy link
Member

Sorry @hata6502 , there are conflicts again 😔

@hata6502
Copy link
Contributor Author

Done!
Conflict means Editor.js is improved frequently :)

@gohabereg
Copy link
Member

@hata6502
Since this one is merged #1601 Tooltip is not a module anymore, so destroy won't be called automatically

@hata6502
Copy link
Contributor Author

Fixed, and I confirmed it works.
Please re-review.

@hata6502
Copy link
Contributor Author

Would you merge this?

@neSpecc neSpecc merged commit 04749ed into codex-team:next Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gohabereg gohabereg gohabereg approved these changes

@neSpecc neSpecc neSpecc approved these changes

@khaydarov khaydarov Awaiting requested review from khaydarov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hata6502 @gohabereg @neSpecc